T7789: T7661: VPP prevent failing to load XDP in clouds (ena/gve drivers) #4747
+147
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
natali-rs1985
force-pushed
the
T7789
branch
3 times, most recently
from
8e406f9 to
b27a553
Compare
dmbaturin
changed the title
dmbaturin
approved these changes
Sep 25, 2025
natali-rs1985
force-pushed
the
T7789
branch
2 times, most recently
from
0a8556d to
4187628
Compare
natali-rs1985
changed the title
natali-rs1985
changed the title
sever-sever
reviewed
Sep 29, 2025
| if rx_queues > max_rx_queues: | ||
| raise ConfigError( | ||
| f'Maximum supported number of RX queues for interface {iface} is {max_rx_queues}. ' | ||
| f'Please set "xdp-options num-rx-queues" to {max_rx_queues} or fewer' |
There was a problem hiding this comment.
It allows to set all, but doesn't allow to set 7 after this
vyos@r14# sudo ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 4
[edit]
vyos@r14#
[edit]
vyos@r14# set vpp settings interface eth1 driver xdp
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues all
[edit]
vyos@r14# commit
[edit]
vyos@r14#
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 8
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
[edit]
vyos@r14#
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 7
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14#
If we try to set 2, afoter those steps:
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 2
[edit]
vyos@r14# commit
[ vpp ]
WARNING: Not all RX queues will be connected to VPP for eth1!
[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
[edit]
vyos@r14#
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Some cloud NICs (ena, gve) fail to load XDP if all RX queues are configured. To avoid this, we limit the number of queues to half of the maximum supported by the driver.
|
CI integration ❌ failed! Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: